Repository navigation
Do not assign macro expansion counters to caller-supplied aliases - #16140
Merged
josevalim merged 3 commits intoNov 17, 2026
Merged
Conversation
Closes elixir-lang#16139. Assisted-by: Codex:GPT-6 Assisted-by: Claude Code:claude-fable-5-2
Member
|
@lukaszsamson do we need these extensive tests as well? Are they covering scenarios we haven't yet? Or should we have a minimal test that matches only the regression? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16139.
do_linifyassigned the expansion counter to everyalias/require/importand__aliases__node in a macro expansion, including caller AST spliced in viaunquote. A caller'salias(or the alias implied bydefmodule) passed as a macro argument was therefore stored as a macro alias and could rebind the macro's own hygienic alias references.The counter is now assigned only to nodes that come from a quote: directives carrying
contextmetadata and aliases carrying thealiasannotation.Directives built by hand without
contextmetadata no longer receive the counter. Aliases emitted by a macro still affect caller code.Assisted-by: Codex:GPT-6
Assisted-by: Claude Code:claude-fable-5-2